[PATCH 4/4] Add a MessageWaiting interface to track message waiting indications.

[andrzej zaborowski]

2009/8/3 Denis Kenzior <denkenz at gmail.com>:
> Lets go with two attributes.  It should give the UI a chance to display the
> indicators differently, depending on what the carrier supports.

Now changed.

>
>> Err, yes we can, but then we don't account for the little corner cases
>> like the two mentioned:
>>
>>  * Special Message Indication IEI says discard the message but DCS
>> says store it.
>
> Sure we do,
> if sms_contains_special_vm_iei(sms):
>        discard = extract_discard_from_iei_data
>        // Quote relevant part of the spec here
>        if mwi_dcs_decode(sms, ... ,dcsdiscard)
>                discard = discard || dcsdiscard  <--- here
>        return

True, now the order of the checks is changed to what you suggested.
If there's an enhanced voicemail IEI then we don't check for other
types of mailboxes, such as email but I suppose it's okay because even
if they're used, they'll very rarely be all in the same message.

Regards
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Add-a-MessageWaiting-interface-to-track-message-wait.patch
Type: application/octet-stream
Size: 26068 bytes
Desc: not available
URL: <http://lists.ofono.org/pipermail/ofono/attachments/20090803/c3b30279/attachment-0001.obj>