[PATCH 4/4] Add a MessageWaiting interface to track message waiting indications.

[andrzej zaborowski]

2009/8/4 Denis Kenzior <denkenz at gmail.com>:
> I've pushed this patch and heavily customized it afterwards to simplify the
> logic a bit.  Can you check that it is still working as intended?

It is kind of working but one of the things "simplified away" is using
the D-Bus interface even without working EF-MBDN or EF-MWIS files on
the SIM, i.e. if the write fails then the user never finds out there
was a notification.

Consistently with the change to return invalid_args on D-Bus type
mismatch, I'm attaching a diff to do the same thing for other
interfaces we have.

You might want to add G_DBUS_METHOD_FLAG_ASYNC to SetProperty
signature and remove mw_update declaration which is now unused.  Also
the check in cache_info should probably be if (r < len).

>
> Writing of MBDN fields is still missing.  Can you send another patch for this?

Sent separately.

> Also one fo writing of MSISDN records in SimManager would be good as well.

Will get on it today.

Regards
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Use-invalid_args-instead-of-invalid_format.patch
Type: text/x-patch
Size: 2740 bytes
Desc: not available
URL: <http://lists.ofono.org/pipermail/ofono/attachments/20090805/ce785c81/attachment-0001.bin>