Read EFad and expose MNC length in IMSI as a SimManager property.

[andrzej zaborowski]

Attaching an updated patch.

2009/8/20 Andrzej Zaborowski <andrew.zaborowski at intel.com>:
> 2009/8/20 Gu, Yang <yang.gu at intel.com>:
>> Several minor comments on this patch:
>> 1. How about unify all the mnc_length to be unsigned char?
>> 2. For this piece of code:
>>>+              value = new_mnc_length;
>>>+              ofono_dbus_signal_property_changed(conn, modem->path,
>>>+                                              SIM_MANAGER_INTERFACE,
>>>+                                              "MNCLength", DBUS_TYPE_BYTE,
>>>+                                              &value);
>> Is it necessary to use temporary variable value? Why not use &sim->mnc_length instead of &value?
>
> Necessary no, we can use unsigned char for sim->mnc_length --
> ofono_dbus_signal_property_changed requires unsigned char * -- it's
> just proper to use ints for integers.  I changed it as you suggest
> nevertheless.
>
>>
>> 3. In function sim_ad_read_cb(), variable "ph" is defined by not used.
>
> Thanks for noticing, removed in the attachment.

Regards
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Read-EFad-and-expose-MNC-length-in-IMSI-as-a-SimMana.patch
Type: text/x-patch
Size: 2753 bytes
Desc: not available
URL: <http://lists.ofono.org/pipermail/ofono/attachments/20090826/16886c8c/attachment.bin>