Expose service dialling numbers stored on SIM through SimManager.

[Andrzej Zaborowski]

Hi,

2009/8/25 Denis Kenzior <denkenz at gmail.com>:
> Please re-base and resubmit this patch, it does not apply cleanly after the
> latest round of changes.
> Also, lets return a dictionary.  Applications already need to parse
> GetProperties, which is a dictionary of strings to variants, so
> string->string shouldn't be a big deal.
>
>>
>> +
>> +       if (sim_adn_parse(data, record_length, &ph, &alpha) == TRUE &&
>> alpha) {
>> +               struct service_number *sdn;
>> +
>> +               sdn = g_new(struct service_number, 1);
>> +               sdn->id = alpha;
>
> Lets make sure that the id is non-empty.  If it is empty, we should we use
> the phone number as the id unless you can think of something better.
>
>>
>> +               memcpy(&sdn->ph, &ph, sizeof(struct ofono_phone_number));
>> +
>> +               sim->service_numbers =
>> +                       g_slist_prepend(sim->service_numbers, sdn);
>
> Do we want to check for id uniqueness here?

Thanks for the remarks, incorporated them in the patch and updated it
to current.

Regards
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Expose-service-dialling-numbers-stored-on-SIM-throug.patch
Type: text/x-patch
Size: 9767 bytes
Desc: not available
URL: <http://lists.ofono.org/pipermail/ofono/attachments/20090826/fa26b5e0/attachment-0001.bin>