[PATCH] Fix a crash during isimodem initialization

Denis Kenzior denkenz at gmail.com
Wed Dec 9 00:03:12 PST 2009


Hi Alex,

> ext Denis Kenzior wrote:
> > While the patch does indeed fix the issue, it does it mostly by accident.
> >  To add insult to injury it also has two style issues, all within 4 lines
> > of code.
>
> I must be blind. Which are the style issues exactly?

We're very pedantic about spacing and blank lines here.  There should be no 
extraneous blank spaces in the code.  And all if statements must be preceded 
by a blank line.  

Your patch resulted in something like:
if (bar) {
	statement
	if (foo) {
		statement
	}

}

and should have been:
if (bar) {
	statement

	if (foo) {
		statement
	}
}

Regards,
-Denis


More information about the ofono mailing list