[PATCH] Fix a crash during isimodem initialization
Alexander Kanavin
alexander.kanavin at nokia.com
Thu Dec 10 02:54:18 PST 2009
ext Denis Kenzior wrote:
> Hi Alex,
>
>> ext Denis Kenzior wrote:
>>> While the patch does indeed fix the issue, it does it mostly by accident.
>>> To add insult to injury it also has two style issues, all within 4 lines
>>> of code.
>> I must be blind. Which are the style issues exactly?
>
> We're very pedantic about spacing and blank lines here. There should be no
> extraneous blank spaces in the code. And all if statements must be preceded
> by a blank line.
Right. Is this documented anywhere, particularly the "blank line before if"
rule?
Alex
More information about the ofono
mailing list