[PATCH] bootstrap: autoconf must run before automake
Rémi Denis-Courmont
remi at remlab.net
Thu Dec 10 06:34:16 PST 2009
On Thu, 10 Dec 2009 15:22:14 +0100, Marcel Holtmann <marcel at holtmann.org>
wrote:
>> Without this, dependencies are not propagated on Ubuntu 9.10.
>> As such, make clean is needed before make all, which is quite annoying.
>
> And what are you talking about? Have this running without issues on
> Ubuntu 9.10 and Fedora 12. I always test both distros. And since exactly
> the same bootstrap files are used in ConnMan, BlueZ and obexd, you do
> have to explain the problem to me. Seems only you are having it since
> nobody else is complaining about it.
I've seen the same behavior on Ismo's machine in another (internal) project
suffering the exact same mistake. That's automake 1.11 and autoconf 2.64.
Basically, depcomp sucks if autoconf is run and automake is not re-run
afterward.
But that's beyond the point. The fact is that autoconf is meant to be run
before automake. I am not interested in arguing with the autotools design
as it is beyond my control. You can check the autoreconf tracing or
automake rules to regenerate configure and Makefile.in's if you can't
believe me.
> So what are your steps that forces you to run make clean before make. I
> am really not seeing it.
The depfiles are simply misgenerated. Touching a header file does not cause
the including modules to be rebuilt. And changing a .c module does not
cause the object file to be recompiled either.
--
Rémi Denis-Courmont
http://www.remlab.net
http://fi.linkedin.com/in/remidenis
-------------- next part --------------
From a11dc84f8a9b82a96555511f4ffba191fe933324 Mon Sep 17 00:00:00 2001
From: =?utf-8?q?R=C3=A9mi=20Denis-Courmont?= <remi.denis-courmont at nokia.com>
Date: Wed, 9 Dec 2009 13:35:37 +0200
Subject: [PATCH] bootstrap: autoconf must run before automake
The other way, dependencies computation (depcomp) does not work
correctly. In fact, aclocal is the part of GNU/automake to be run
before autoconf whereas automake is the part to be run after it.
In other words, aclocal would not exist if automake could run
properly before autoconf. This ordering is consistent with most
autotools-based projects, and most authoritatively, with autoreconf.
This also adds a missing anti-slash for consistency.
---
bootstrap | 7 ++++---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/bootstrap b/bootstrap
index 053f5c8..a71f1d6 100755
--- a/bootstrap
+++ b/bootstrap
@@ -2,6 +2,7 @@
aclocal && \
autoheader && \
- libtoolize --automake --copy --force &&
- automake --add-missing --copy && \
- autoconf
+ libtoolize --automake --copy --force && \
+ autoconf && \
+ automake --add-missing --copy
+
--
1.6.3.3
More information about the ofono
mailing list