[PATCH 1/4] Enhance topic range list utilities
Denis Kenzior
denkenz at gmail.com
Wed Dec 16 09:30:07 PST 2009
Hi Andrew,
> The functions need to handle full 16-bit range to be useful for EFcbmid
> handling.
> ---
> src/smsutil.c | 28 ++++++++++++++++++++++++----
> src/smsutil.h | 2 ++
> 2 files changed, 26 insertions(+), 4 deletions(-)
>
> diff --git a/src/smsutil.c b/src/smsutil.c
> index c27e937..d5169f0 100644
> --- a/src/smsutil.c
> +++ b/src/smsutil.c
> @@ -3509,12 +3509,12 @@ out:
> return TRUE;
> }
>
> -static GSList *cbs_optimize_ranges(GSList *ranges)
> +GSList *cbs_optimize_ranges(GSList *ranges)
> {
> struct cbs_topic_range *range;
> - unsigned char bitmap[125];
> + unsigned char bitmap[8192];
Allocating 8 extra k just for EFcbmid is really too high a price to pay, can
we get away simply passing this on? Most of the time it will be higher than
999 anyway.
Regards,
-Denis
More information about the ofono
mailing list