[PATCH 3/4] Add Powered property to CbsManager.

[Andrzej Zaborowski]

Hi Denis,

2009/12/16 Denis Kenzior <denkenz at gmail.com>:
> You should still be able to set the topics even if powered=false.  Simply
> store the new list and send it to the modem if powered==true.

This is what the code does afaict.

>
>>
>> -     cbs->pending = dbus_message_ref(msg);
>> +     topic_str = cbs_topics_to_str(cbs, topics);
>>       cbs->driver->set_topics(cbs, topic_str, cbs_set_topics_cb, cbs);
>>       g_free(topic_str);
>>
>>       return NULL;
>>  }
>>
>> +static void cbs_power_off_cb(const struct ofono_error *error, void *data)
>> +{
>> +}
>> +
>
> Lets return the reply once the operation has succeeded at the driver to be
> consistent with other parts of the system.

Okay, changed the behaviour to reply in the callback.  The reason I
chose to reply immediately was that we don't mind it if the command
fails at the modem.

Regards
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Add-Powered-property-to-CbsManager.patch
Type: text/x-patch
Size: 7261 bytes
Desc: not available
URL: <http://lists.ofono.org/pipermail/ofono/attachments/20091217/e77cafb4/attachment.bin>