[PATCH 3/4] Add Powered property to CbsManager.
Denis Kenzior
denkenz at gmail.com
Thu Dec 17 19:55:22 PST 2009
Hi Andrew,
> > You should still be able to set the topics even if powered=false. Simply
> > store the new list and send it to the modem if powered==true.
>
> This is what the code does afaict.
Yes you're right, I misread the code.
> > Lets return the reply once the operation has succeeded at the driver to
> > be consistent with other parts of the system.
>
> Okay, changed the behaviour to reply in the callback. The reason I
> chose to reply immediately was that we don't mind it if the command
> fails at the modem.
No biggie, just preserving the consistency.
Patch has been applied with tiny fixes to style afterward. Thanks.
Regards,
-Denis
More information about the ofono
mailing list