[PATCH] Support 51.011 EFecc format.

Denis Kenzior denkenz at gmail.com
Thu Dec 17 20:12:06 PST 2009


Hi Andrew,

> Now with the attachment..
> 

Some comments:

 struct ofono_sim {
 	char *imsi;
+	int phase;
 	unsigned char mnc_length;
 	GSList *own_numbers;
 	GSList *new_numbers;

Enum or an unsigned char for phase please.

+	sim->phase = (ok && length == 1) ? data[0] == 0x00 ? 1 : 2 : 3;
+

This seriously makes my brain hurt.  Don't do this.

Regards,
-Denis


More information about the ofono mailing list