[PATCH 3/4] Fix possible memory leak on SIM reading error.

Andrzej Zaborowski andrew.zaborowski at intel.com
Thu Jul 30 01:05:32 PDT 2009


This would also stall the SIM op queue if there's a read error for a record
other than the first.  The other solution would be "goto next;" (keep
reading further records).
---
 src/sim.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/src/sim.c b/src/sim.c
index deab6bd..695744f 100644
--- a/src/sim.c
+++ b/src/sim.c
@@ -317,9 +317,7 @@ static void sim_op_retrieve_cb(const struct ofono_error *error,
 	int fd;
 
 	if (error->type != OFONO_ERROR_TYPE_NO_ERROR) {
-		if (op->current == 1)
-			sim_op_error(modem);
-
+		sim_op_error(modem);
 		return;
 	}
 
-- 
1.6.1



More information about the ofono mailing list