add a common exit function for interfaces when manager_free and manager_destroy function is called

Li, Minjun minjun.li at intel.com
Tue Jun 2 18:11:37 PDT 2009


I regenerated the patch again.
Thank denis for good advice.

Best Regards,

Minjun
-----Original Message-----
From: Kenzior, Denis 
Sent: 2009年6月3日 6:38
To: ofono at ofono.org
Cc: Li, Minjun
Subject: Re: add a common exit function for interfaces when manager_free and manager_destroy function is called

Hi Minjun,

On Tuesday 02 June 2009 02:02:29 Li, Minjun wrote:
> Hi Folks,
> I regenerated the patch.
> Because I found that manager_destroy function is lack of some exit function
> calls comparing to manager_free function, I add a common exit function for
> interfaces when manager_free and manager_destroy function is called.
>

In interface_exit: Please remove if (at)  block, its pointless.

Please get rid of all mode changes, only submit changes to files that are 
relevant to the fix.

Get a proper commit message.  E.g. put the description in the email into the 
commit message.  

> Best Regards,
> Minjun

Regards,
-Denis

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Adding-a-common-exit-function-for-interfaces-when-ma.patch
Type: application/octet-stream
Size: 2008 bytes
Desc: 0001-Adding-a-common-exit-function-for-interfaces-when-ma.patch
URL: <http://lists.ofono.org/pipermail/ofono/attachments/20090603/466f989a/attachment.obj>


More information about the ofono mailing list