add a common removing and unregistering exit function for interfaces when manager_free and manager_destroy function is called

Xu, Martin martin.xu at intel.com
Tue Jun 2 19:25:13 PDT 2009


Hi Mingjun:
Since it uses the kernel coding style, you can use checkpatch.pl from kernel to check your patch before you submit it. :)
I have attached the script in my attachment in case you are not familiar with kernel. 

-----Original Message-----
From: ofono-bounces at ofono.org [mailto:ofono-bounces at ofono.org] On Behalf Of Denis Kenzior
Sent: 2009年6月2日 11:58
To: ofono at ofono.org
Subject: Re: add a common removing and unregistering exit function for interfaces when manager_free and manager_destroy function is called

Hi Minjun,

On Monday 01 June 2009 20:18:23 Li, Minjun wrote:
> Hi Folks,
> Because I found that manager_destroy function is lack of some exit function
> calls comparing to manager_free function, I add a common removing and
> unregistering exit function for interfaces when manager_free and
> manager_destroy function is called.

Please use proper coding style when submitting patches.  This means tabs 
instead of spaces, and proper spacing, e.g. 'if () {'  The functions should be 
named appropriately, 'foo_free' just won't work.

Also, only include patches that are specific to the fix, things like mode change 
are extraneous.   And include a proper commit message.

>
> Best Regards,
> Minjun

Regards,
-Denis
_______________________________________________
ofono mailing list
ofono at ofono.org
http://lists.ofono.org/listinfo/ofono
-------------- next part --------------
A non-text attachment was scrubbed...
Name: checkpatch.pl
Type: application/octet-stream
Size: 70566 bytes
Desc: checkpatch.pl
URL: <http://lists.ofono.org/pipermail/ofono/attachments/20090603/926e4f09/attachment-0001.obj>


More information about the ofono mailing list