two patches for voicecall.c

Leandro Dorileo ldorileo at gmail.com
Wed May 27 05:58:17 PDT 2009


Hi Minjun

On Wed, May 27, 2009 at 3:46 AM, Li, Minjun <minjun.li at intel.com> wrote:
> Hi Folks,
> I have made 2 patches for minor bugs in functions of voicecall_busy and dial_callback in /src/voicecall.c.
> The first one is to use the function pointer set_udub to replace release_specific.
> The second one is to delete the repeated calling of voicecall_create in dial_callback function, since it was called in previous line in the same function.


I re-read your patch and voicecall.c source code comparing your
changes, your patch seems to be ok, but your log message doesn`t seem
to describe well your changes, your first patch tells in the
subject(file name and so on) you changed the function pointer(on
something not specified) but you changed the verification of it.

Regards...

-- 
(°=   Leandro Dorileo
//\    ldorileo at gmail.com   -   http://www.dorilex.net
V_/  Software is a matter of freedom.


More information about the ofono mailing list