[PATCH 1/1] Create network registration driver for hfpmodem

[Gustavo F. Padovan]

Hi Zhenhua,

On Tue, Nov 3, 2009 at 3:46 PM, Zhenhua Zhang <zhenhua.zhang at intel.com> wrote:
> Hi Padovan,
>
> Gustavo F. Padovan wrote:
>> This driver handles phone informations about registration status, signal
>> strength and roaming status listening +CIEV commands.  It also gets the
>> Network Operator name with +COPS commands.
>> ---
>>  Makefile.am                             |    3 +-
>>  drivers/hfpmodem/hfpmodem.c             |    2 +
>>  drivers/hfpmodem/hfpmodem.h             |    3 +
>>  drivers/hfpmodem/network-registration.c |  365 +++++++++++++++++++++++++++++++
>>  plugins/hfp.c                           |    1 +
>>  5 files changed, 373 insertions(+), 1 deletions(-)
>>  create mode 100644 drivers/hfpmodem/network-registration.c
>
> On compiling your code I got:
>
>  CC     drivers/hfpmodem/network-registration.o
> cc1: warnings being treated as errors
> drivers/hfpmodem/network-registration.c: In function ‘cops_cb’:
> drivers/hfpmodem/network-registration.c:101: error: label ‘error’
> defined but not used
> drivers/hfpmodem/network-registration.c:58: error: unused variable ‘nd’
> make[1]: *** [drivers/hfpmodem/network-registration.o] Error 1
> make: *** [all] Error 2

Sorry, I forgot the --enable-maintainer-mode. :(

>
> So I have below patch to remove 'nd' and refine labels in cops_cb.
> Please review it.
>
> I would suggest to replace 'out' label by return. We really don't need
> two labels that is confusing. Atmodem netreg has the same problem.

I agree with you, thanks for the patch and the review.


-- 
Gustavo F. Padovan
ProFUSION embedded systems - http://profusion.mobi