[PATCH 1/4] add interface property to primary context

Denis Kenzior denkenz at gmail.com
Mon Nov 9 08:57:15 PST 2009


Hi Martin,

> @@ -37,6 +37,7 @@ struct ofono_gprs_context;
>  struct ofono_gprs_primary_context {
>  	unsigned int cid;
>  	int direction;
> +	char *interface;
>  	char apn[OFONO_GPRS_MAX_APN_LENGTH + 1];
>  	char username[OFONO_GPRS_MAX_USERNAME_LENGTH + 1];
>  	char password[OFONO_GPRS_MAX_PASSWORD_LENGTH + 1];

Logically this does not belong here.  It should be added to 
ofono_gprs_context, or perhaps to pri_context.

Regards,
-Denis


More information about the ofono mailing list