Patch on unsupported AT command
Marcel Holtmann
marcel at holtmann.org
Tue Nov 17 12:35:34 PST 2009
Hi Denis,
> >+ g_at_chat_add_terminator(chat, "+EXT ERROR:", 11, FALSE);
> >+ g_at_chat_add_terminator(chat, "+CME ERROR:", 11, FALSE);
> >+ g_at_chat_add_terminator(chat, "+CMS ERROR:", 11, FALSE);
> >+ g_at_chat_add_terminator(chat, "NO ANSWER", -1, FALSE);
> >+ g_at_chat_add_terminator(chat, "CONNECT", -1, TRUE);
> >+ g_at_chat_add_terminator(chat, "NO CARRIER", -1, FALSE);
> >+ g_at_chat_add_terminator(chat, "BUSY", -1, FALSE);
> >+ g_at_chat_add_terminator(chat, "NO DIALTONE", -1, FALSE);
> >+ g_at_chat_add_terminator(chat, "ERROR", -1, FALSE);
> >+ g_at_chat_add_terminator(chat, "OK", -1, TRUE);
>
> I really don't like this. Lets keep the non-standard terminators in a
> separate list. I don't want the vast majority of the drivers incurring the
> cost of multiple g_new/g_frees.
I have to agree on this. We should keep the penalty for well behaving
cards as small as possible.
Regards
Marcel
More information about the ofono
mailing list