[PATCH] SetProperty method and Powered property missing from modem-api doc.

[Marko Saukko]

Hi,

SetProperty method and Powered Property where missing from modem-api.txt

Question:

I'm not sure if the "On success a PropertyChanged signal will be emitted."
message is valid, as the PropertyChanged signal is sent only once when doing
for example the following:

$ dbus-send --print-reply --system --dest=org.ofono /atgen0
org.ofono.Modem.SetProperty string:Powered variant:boolean:true
method return sender=:1.160 -> dest=:1.227 reply_serial=2
$ dbus-send --print-reply --system --dest=org.ofono /atgen0
org.ofono.Modem.SetProperty string:Powered variant:boolean:true
method return sender=:1.160 -> dest=:1.228 reply_serial=2

If I understood correctly the second method call is also successfull
eventhough no PropertyChanged signal is emitted.

Regards,
Marko

---
 doc/modem-api.txt |   17 ++++++++++++++++-
 1 files changed, 16 insertions(+), 1 deletions(-)

diff --git a/doc/modem-api.txt b/doc/modem-api.txt
index 3058880..06a4ada 100644
--- a/doc/modem-api.txt
+++ b/doc/modem-api.txt
@@ -12,12 +12,27 @@ Methods             dict GetProperties()

                        Possible Errors: [service].Error.InvalidArguments

+               void SetProperty(string property, variant value)
+
+                       Changes the value of the specified property. Only
+                       properties that are listed as read-write are
+                       changeable. On success a PropertyChanged signal
+                       will be emitted.
+
+                       Possible Errors: [service].Error.InvalidArguments
+                                        [service].Error.DoesNotExist
+
 Signals                PropertyChanged(string name, variant value)

                        This signal indicates a changed value of the given
                        property.

-Properties     string Manufacturer [readonly, optional]
+Properties     boolean Powered [readwrite]
+
+                       Boolean representing the power state of the modem
+                       device.
+
+               string Manufacturer [readonly, optional]

                        String representing the manufacturer of the modem
                        device.
--
1.6.0.4
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ofono.org/pipermail/ofono/attachments/20091019/e166e418/attachment.html>