[PATCH] When setting the serial port, the previous settings need to be preserved.

[Ryan Raasch]

Denis Kenzior wrote:
> Hi Ryan,
> 
>> This took a while to locate. Shouldn't it be possible to use stty
>> outside the daemon, and then daemon would just continue as usual?
>>
>> In my case, the cread was being removed, so no input data could be read.
> 
> Sorry but the patch is wrong, since you're blowing away all options that have 
> been set via the GHashTable.

Yea. Sorry. Put it in the wrong place, uggh. It should go before setting 
the options, since the switches are or'ing and xor'ing.

> 
> GAtTty is really a convenience method, if you need something specific, pass the 
> option in the GHashTable or setup the fd however you wish by yourself.
> 
> Regards,
> -Denis

But, there is a problem with the opening of the serial port b/c the 
CREAD flag is destroyed if it is active, making the serial port unreadable.

Ryan

> _______________________________________________
> ofono mailing list
> ofono at ofono.org
> http://lists.ofono.org/listinfo/ofono
-------------- next part --------------
A non-text attachment was scrubbed...
Name: serial_port_enable_CREAD.patch
Type: text/x-patch
Size: 1410 bytes
Desc: not available
URL: <http://lists.ofono.org/pipermail/ofono/attachments/20091020/97927e6a/attachment.bin>