[PATCH] When setting the serial port, the previous settings need to be preserved.

[Ryan Raasch]

Hello,

I have attached a small patch which allows gattty.c to enable/disable 
the read functionality on the serial port.

Cheers,
Ryan

Denis Kenzior wrote:
> Hi Ryan,
> 
>>> You're blowing away the result of cfmakeraw.  Most of the devices are not
>>> true serial devices and so do not need any of the special options. 
>>> Passing a NULL options GHashTable should result in cfmakeraw.  Why don't
>>> you just pass all the options you need instead of using tcgetattr?
>> Should i just move the tcgetattr() to happen before cfmakeraw()?
> 
> Only one (executed last) will have effect, and I want it to be the cfmakeraw.  
> So simply get rid of tcgetattr.
> 
>>> The other parts of the patch look good to me.
>> Ok. Why don't i just add the string options ("read", others...) in
>> gattty.c?
> 
> This is what I would prefer.
> 
> Regards,
> -Denis
> _______________________________________________
> ofono mailing list
> ofono at ofono.org
> http://lists.ofono.org/listinfo/ofono
-------------- next part --------------
A non-text attachment was scrubbed...
Name: serial_port_enable_CREAD.patch
Type: text/x-patch
Size: 861 bytes
Desc: not available
URL: <http://lists.ofono.org/pipermail/ofono/attachments/20091021/0af4724f/attachment.bin>