[PATCH 2/2] Altered the atgeneric modem to include the added modem.conf options.

Ryan Raasch ryan.raasch at gmail.com
Thu Oct 29 09:29:34 PDT 2009


2009/10/29 Denis Kenzior <denkenz at gmail.com>:
> Hi Ryan,
>
>> The modem.conf options for the driver portion of the patch.
>
> Patch has been applied with some refactoring afterward.  I know you ran
> checkpatch.pl, but please make sure you follow the coding standard even for
> parts which checkpatch.pl does not catch.  In particular:
>
>> +static const char *tty_opts[] =
>> +  {
>> +       "Baud",
>> +       "Read",
>> +       "Local",
>> +       "StopBits",
>> +       "DataBits",
>> +       "Parity",
>> +       "XonXoff",
>> +       "Rtscts",
>> +       NULL,
>> +  };
>
> - There are spaces for indentation, ONLY tabs should be used.
> - The opening brace should be on the tty_opts line.
>
Thanks. I will make sure next time.

Greetings,
Ryan

> _______________________________________________
> ofono mailing list
> ofono at ofono.org
> http://lists.ofono.org/listinfo/ofono
>


More information about the ofono mailing list