[PATCH] G1: Add an SMS quirk for CNMI mode

Bastian, Waldo waldo.bastian at intel.com
Thu Sep 3 08:42:52 PDT 2009


> -	/* Mode doesn't matter, but sounds like 2 is the sanest option */
> -	if (!append_cnmi_element(buf, &len, cnmi_opts[0], "2310", FALSE))
> +	if (data->vendor == OFONO_VENDOR_HTC_G1)
> +		/* The G1 advertises support for mode 2, but returns an error
> +		 * if we attempt to actually use it. */
> +		mode = "1";
> +	else
> +		/* Sounds like 2 is the sanest mode */
> +		mode = "2310";
> +
> +	if (!append_cnmi_element(buf, &len, cnmi_opts[0], mode, FALSE))
>  		return FALSE;

Instead of having vendor checks all over the place, wouldn't it be cleaner if the plugin had a way to provide/fix cnmi_opts?

Cheers,
Waldo


More information about the ofono mailing list