[PATCH] [RFC] Do the PIN check in SIMManager

[andrzej zaborowski]

Hi,

2009/9/22 Denis Kenzior <denkenz at gmail.com>:
>> authentication, you have to give the old password from before it was
>> changed to "", i.e to disable and enable SIM PIN, do:
>> SimManager.ChangePin("pin", "1234", "")
>> SimManager.ChangePin("pin", "1234", "1234")
>>
>> rather than the more logical
>>
>> SimManager.ChangePin("pin", "1234", "")
>> SimManager.ChangePin("pin, "", "1234)
>>
>> The other problem is that if changing the password succeeds but
>> enabling authentiation fails, ChangePin still returns failure
>
> I added LockPin and UnlockPin methods to take care of these two cases.

Should we have a read-only property so clients know what the current
state is?  Unfortunately this would be some 6 properties and 6 more
commands on startup, for little gain.  I attached a diff to add plugin
interface for this without dbus interface.  The other two changes are
just clean-up.

Regards
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Update-sim-api.txt-ChangePin-no-longer-disables-pin.patch
Type: text/x-patch
Size: 750 bytes
Desc: not available
URL: <http://lists.ofono.org/pipermail/ofono/attachments/20090923/d21e1e99/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Add-a-plugin-interface-for-getting-PIN-lock-state.patch
Type: text/x-patch
Size: 3493 bytes
Desc: not available
URL: <http://lists.ofono.org/pipermail/ofono/attachments/20090923/d21e1e99/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Remove-unused-struct-field.patch
Type: text/x-patch
Size: 654 bytes
Desc: not available
URL: <http://lists.ofono.org/pipermail/ofono/attachments/20090923/d21e1e99/attachment-0002.bin>