[PATCH] Fix Let data device be optional for mbm driver

[Vdovichev Alexander]

Hi Marcel,

On 04/16/2010 10:52 PM, Marcel Holtmann wrote:
> Hi Zhenhua,
>
>> Dell 5530 modem has no data device port. So data device should be
>> optional in mbm drvier.
>
> can you please include the content of /proc/bus/usb/devices for this
> device and the sysfs descriptions for each TTY port.

I realize my previous fix is not proper to 5530. I can see three ports 
(ttyACM0~ttyACM2) for Dell 5530 modem. The sysfs descriptions are posted 
at below URLs:

ttyACM0	http://pastebin.com/aW4PyHBw
ttyACM1	http://pastebin.com/igZxccVe
ttyACM2	http://pastebin.com/T7DFmXTv

ttyACM0 is described as 'Dell Wireless 5530 HSPA Mobile Broadband 
Minicard Modem'.

ttyACM1 is described as 'Dell Wireless 5530 HSPA Mobile Broadband 
Minicard Modem 2'.

I cann't tell which one is modem device or data device. But obviously, 
we should add 'Minicard Modem 2' as suffix candidate. So my updated 
patch is attached. Now we can probe 5530 correctly again. the output is:

ofonod[3737]: src/modem.c:ofono_modem_create() name: 3558620217367190, 
type: mbm
ofonod[3737]: src/modem.c:set_modem_property() modem 0x8a576c0 property Path
ofonod[3737]: src/modem.c:set_modem_property() modem 0x8a576c0 property 
Registered
ofonod[3737]: plugins/udev.c:add_mbm() desc: Dell Wireless 5530 HSPA 
Mobile Broadband Minicard Modem
ofonod[3737]: src/modem.c:get_modem_property() modem 0x8a576c0 property 
Registered
ofonod[3737]: src/modem.c:get_modem_property() modem 0x8a576c0 property 
ModemDevice
ofonod[3737]: src/modem.c:set_modem_property() modem 0x8a576c0 property 
ModemDevice
ofonod[3737]: src/modem.c:get_modem_property() modem 0x8a576c0 property 
ModemDevice
ofonod[3737]: src/modem.c:get_modem_property() modem 0x8a576c0 property 
NetworkInterface
ofonod[3737]: src/modem.c:get_modem_property() modem 0x8a576c0 property Path
ofonod[3737]: plugins/udev.c:add_mbm() desc: Dell Wireless 5530 HSPA 
Mobile Broadband Minicard Modem 2
ofonod[3737]: src/modem.c:get_modem_property() modem 0x8a576c0 property 
Registered
ofonod[3737]: src/modem.c:get_modem_property() modem 0x8a576c0 property 
ModemDevice
ofonod[3737]: src/modem.c:set_modem_property() modem 0x8a576c0 property 
DataDevice
ofonod[3737]: src/modem.c:get_modem_property() modem 0x8a576c0 property 
ModemDevice
ofonod[3737]: src/modem.c:get_modem_property() modem 0x8a576c0 property 
NetworkInterface
ofonod[3737]: src/modem.c:get_modem_property() modem 0x8a576c0 property Path
ofonod[3737]: plugins/udev.c:add_mbm() desc: Dell Wireless 5530 HSPA 
Mobile Broadband Minicard NetworkAdapter
ofonod[3737]: src/modem.c:get_modem_property() modem 0x8a576c0 property 
Registered
ofonod[3737]: src/modem.c:set_modem_property() modem 0x8a576c0 property 
NetworkInterface
ofonod[3737]: src/modem.c:get_modem_property() modem 0x8a576c0 property 
ModemDevice
ofonod[3737]: src/modem.c:get_modem_property() modem 0x8a576c0 property 
NetworkInterface
ofonod[3737]: src/modem.c:set_modem_property() modem 0x8a576c0 property 
Registered
ofonod[3737]: src/modem.c:unregister_property() property 0x8a57ee0

> Regards
>
> Marcel
>
>
> _______________________________________________
> ofono mailing list
> ofono at ofono.org
> http://lists.ofono.org/listinfo/ofono
>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: winmail.dat
Type: application/ms-tnef
Size: 6152 bytes
Desc: not available
URL: <http://lists.ofono.org/pipermail/ofono/attachments/20100419/47b5f0a8/attachment.bin>