[PATCH 05/17] Add parser for service record objects

[Gu, Yang]

Hi Denis,



>-----Original Message-----
>From: ofono-bounces at ofono.org [mailto:ofono-bounces at ofono.org] On Behalf Of
>Denis Kenzior
>Sent: Wednesday, April 21, 2010 5:56 AM
>To: ofono at ofono.org
>Subject: Re: [PATCH 05/17] Add parser for service record objects
>
>Hi Yang,
>
>> +	sr->serv_rec = g_try_malloc(sr->len);
>> +	if (sr->serv_rec == NULL)
>> +		return FALSE;
>
>I suggest not trying to allocate 0 bytes.

The service record field is either meaningful value or "00", so it will never allocate 0 byte. Other patches are modified following this comment.

>
>Regards,
>-Denis
>_______________________________________________
>ofono mailing list
>ofono at ofono.org
>http://lists.ofono.org/listinfo/ofono

Regards,
-Yang