[PATCH] Fix set default baud rate to 115200

Denis Kenzior denkenz at gmail.com
Tue Jan 5 08:32:25 PST 2010


Hi Zhenhua,

> Hi,
> 
> I found N900 could not be powered on by atgen driver due to baud rate
>  problem. If I add 'Baud=115200' into modem.conf, everything is fine. In
>  gatchat/gattty.c, the default baud rate is B0 which looks not correct, so

gattty code sets the serial port into raw mode if no options are given.  These 
days it is hard to find a real serial port device that actually needs the 
options setup properly.  Most simply work in raw mode.

>  I wonder whether we should set the default baud rate to some values like
>  minicom does.
> 
> My proposed fix was attached.

The fix should really be inside atgen.c, as it logically belongs there.  You 
can make atgen use 'sane' defaults for true serial devices, but then you need 
to add capability to put the modem into 'raw' mode.

Regards,
-Denis


More information about the ofono mailing list