[RFC] HFP support into oFono and BlueZ

Marcel Holtmann marcel at holtmann.org
Tue Jan 12 17:44:44 PST 2010


Hi Denis,

> Initial impressions:
> 
> +static DBusConnection *connection;
> +static char *ofono_handsfree_path;
> +
> +
> +static int timeout;
> +
> 
> These globals seem to belong in per-modem user data unless you only want 1 HFP 
> device per system?

the DBusConnection is fine as a global since it is shared for the whole
process anyway.

For the other two, I agree, they have to be per modem.

Regards

Marcel




More information about the ofono mailing list