[RFC v2 0/7] STE-plugin: Second RFC on STE patch-set
Marcel Holtmann
marcel at holtmann.org
Tue Jan 19 10:56:50 PST 2010
Hi Sjur,
> This is the second RFC on the STE driver.Most review
> comments should be included, except for using glib for
> XML parsing and changes to voice-call termination.
> We'll have to get back to this later.
we are getting to closer to something that can be merged as a first
draft and then later extended.
> Sjur Brandeland (7):
> STE-plugin: Add --disable-stemodem to makefiles.
> STE-plugin: Add vendor STE and quirks in atmodem.
> STE-plugin: STE modem driver definition
> STE-plugin: Add STE plugin
> STE-plugin: Voicecall driver.
> STE-plugin: Add CAIF header files in gcaif.
> STE-plugin: GPRS driver.
So the order of these patches is kinda messed up. Think about it like
this; only adding patch 1 makes the compilation and hence git bisect
break. That should be the last patch.
Also you are adding CAIF headers after you already rely on them in a
previous patch.
Regards
Marcel
More information about the ofono
mailing list