[RFC v2 3/7] STE-plugin: STE modem driver definition

[Marcel Holtmann]

Hi Sjur,

> Updates after review: Removed overriding of functions.
> ---

<snip>

> +
> +#ifdef HAVE_CONFIG_H
> +#include <config.h>
> +#endif
> +
> +#include <glib.h>
> +#include <gatchat.h>

What are these two includes for?

> +#define OFONO_API_SUBJECT_TO_CHANGE
> +#include <ofono/plugin.h>
> +#include <ofono/types.h>

Why do you need the ofono/types.h include. Seems like some leftovers.

> +#include "stemodem.h"
> +
> +static int stemodem_init(void)
> +{
> +	ste_voicecall_init();
> +	ste_gprs_context_init();
> +
> +	return 0;
> +}

As I explained in the introductory reply. You have to keep the order
properly. So this patch either has to come last or the modem init needs
to be empty. You don't have the voicecall or GPRS init function merged
at this point.

If you wanna merge the stemodem.c and the configure option at some
point, I am perfectly fine with that. Just make it an empty stub here so
we are not breaking git bisect.

Together with the other two patches, I would apply that right away.

Regards

Marcel