[PATCH] add quirk for cid and lac handling for Huawei
Denis Kenzior
denkenz at gmail.com
Wed Jan 20 08:26:23 PST 2010
Hi Jussi,
> Attached is my attempt at that. The actual quirk is in
> drivers/atmodem/atutil.c, which means I needed to change the
> at_util_parse_reg*() definitions. Let me know if my approach seems wrong
> -- this was the first time I've even looked at ofono code, and I can't
> claim to understand it fully.
I'm actually fine with this approach. Patch has been applied. I did a trivial
style fix afterward to keep the line length less than 80 characters.
>
> The huawei plugin seems to use OFONO_VENDOR_QUALCOMM_MSM for sms...
> Should that be updated so OFONO_VENDOR_HUAWEI (which I added) hits the
> same quirk(s) or do Huawei and Qualcomm really have something in common?
Huawei uses Qualcomm chips in their devices and thus share the same 'quirks'.
I expect the vendor.h quirks to get refined over time anyway, so for now it is
fine to leave it the way it is.
Thanks,
-Denis
More information about the ofono
mailing list