[PATCH 0/6] STE-plugin
Marcel Holtmann
marcel at holtmann.org
Mon Jan 25 12:07:21 PST 2010
Hi Sjur,
> This is a new version of the STE-plugin patch set. Since last RFCv2 we have
> stubbed out Voice Call and GPRS Context handling, changed patch order,
> cleanup some unnecessary includes, moved CAIF header files, and fixed
> most other review comments (hopefully).
I applied all of your 6 patches. However there were some issues with
your submission.
First, please make sure you have a proper .gitconfig with your email
address and author set correct. That way we keep the GIT history clean
and readable. I had to fix this up on all your patches.
Second, please do proper commit messages. Either one line describes what
your are doing (will end up as Subject) or one line and then a body
describing the details. Check the GIT history for examples.
Third, please ensure that "make distcheck" builds properly. I had to fix
it up for the CAIF header files.
Regards
Marcel
More information about the ofono
mailing list