[PATCH 2/3] huawei: Add Huawei EM770 modem support

[Zhang, Zhenhua]

Hi Marcel,

Marcel Holtmann wrote:
> Hi Zhenhua Zhang,
> 
>> Huawei EM770W is a 3G WCDMA modem that supports
>> HSPA/UMTS/EDGE/GPRS/GSM data service and WCDMA/GSM short message
>> services. It also has voice call capability that supports both 2G
>>  and 3G network. --- plugins/huawei.c    |   31
>>  ++++++++++++++++++++++++++++++- plugins/ofono.rules |    3 +++
>>  plugins/udev.c      |    3 +++
>>  3 files changed, 36 insertions(+), 1 deletions(-)
>> 
>> diff --git a/plugins/udev.c b/plugins/udev.c
>> index 09ee93e..7d34b0b 100644
>> --- a/plugins/udev.c
>> +++ b/plugins/udev.c
>> @@ -227,6 +227,9 @@ static void add_huawei(struct ofono_modem *modem,
>>  		const char *name = udev_list_entry_get_name(entry);
>>  		type = udev_list_entry_get_value(entry);
>> 
>> +		if (g_str_equal(name, "ID_MODEL_ID") == TRUE)
>> +			ofono_modem_set_string(modem, "Model", type);
>> +
> 
> so this is the part that I don't like. I prefer we have some udev
> rules that create OFONO_HUAWEI_VOICE=1 and we use that as indicator
> to enable voice capabilities or not. 

Okay. Will resend out patches and rebase it to latest git tree. Thanks.
 
> Regards
> 
> Marcel
> 
> 
> _______________________________________________
> ofono mailing list
> ofono at ofono.org
> http://lists.ofono.org/listinfo/ofono



Regards,
Zhenhua