[SMS D-Bus 04/23] write_file: make transaction-safe
Inaky Perez-Gonzalez
inaky.perez-gonzalez at intel.com
Fri Jul 2 14:25:22 PDT 2010
On Fri, 2010-07-02 at 13:39 -0700, Denis Kenzior wrote:
> Hi Inaky,
>
> On 06/25/2010 06:15 PM, Inaky Perez-Gonzalez wrote:
> > From: Inaky Perez-Gonzalez <inaky.perez-gonzalez at intel.com>
> >
> > write_file(), as written wasn't transaction-safe; a crash bewtween a
> > file being open and the buffer being written before a safe close would
> > leave the file with a set of undetermined contents.
> >
> > Modified to the file is written to a temporary file name; once
> > completed, it is renamed to the final name. This way, a crash in the
> > middle doesn't leave half-baked files.
>
> Patch is fine, but:
>
> Applying: write_file: make transaction-safe
> /home/denkenz/ofono-master/.git/rebase-apply/patch:13: trailing whitespace.
> /*
Yup, sorry, I missed those. They have been cleaned up already -- next
resubmit will have it fixed.
More information about the ofono
mailing list