[PATCH 1/1] ppp: Add MAX_IPCP_FAILURE to avoid timeout quickly

[Zhang, Zhenhua]

Marcel Holtmann wrote:
> Hi Zhenhua,
> 
>> We use IPCP NAK response to stall the progress of acquiring the
>> client IP address from DHCP server. So we need to increase the max
>> failure of NAKs in IPCP handshaking. ---
>>  gatchat/ppp_cp.c   |    8 ++++++--
>>  gatchat/ppp_cp.h   |    2 +-
>>  gatchat/ppp_ipcp.c |   10 +++++++++-
>>  gatchat/ppp_lcp.c  |    2 +-
>>  4 files changed, 17 insertions(+), 5 deletions(-)
>> 
>> diff --git a/gatchat/ppp_cp.c b/gatchat/ppp_cp.c
>> index 647e241..e013283 100644
>> --- a/gatchat/ppp_cp.c
>> +++ b/gatchat/ppp_cp.c
>> @@ -997,7 +997,7 @@ void pppcp_set_local_options(struct pppcp_data
>> *pppcp,  } 
>> 
>>  struct pppcp_data *pppcp_new(GAtPPP *ppp, const struct pppcp_proto
>> *proto, -				gboolean dormant) +				gboolean dormant, int
>> max_failure) 
> 
> since the value is actually unsigned here, please also use guint and
> not int for this parameter.

Okay. Will resend the patch soon.

> Regards
> 
> Marcel
> 
> 
> _______________________________________________
> ofono mailing list
> ofono at ofono.org
> http://lists.ofono.org/listinfo/ofono



Regards,
Zhenhua