[PATCH 1/9] stkutil: display text attributes as html

[Kristen Carlson Accardi]

On Thu, 08 Jul 2010 17:49:56 -0500
Denis Kenzior <denkenz at gmail.com> wrote:

> > +		/*
> > +		 * if the alignment is the same as either the default
> > +		 * or the last alignment used, don't set any alignment
> > +		 * value.
> > +		 */
> > +		if (start == 0)
> > +			align = STK_DEFAULT_TEXT_ALIGNMENT;
> > +		else {
> > +			align = (formats[start - 1] & 0xFF) &
> > +					STK_TEXT_FORMAT_ALIGN_MASK;
> > +			if (align == STK_TEXT_FORMAT_NO_ALIGN)
> > +				align = STK_DEFAULT_TEXT_ALIGNMENT;
> > +		}
> > +
> > +		if ((code & STK_TEXT_FORMAT_ALIGN_MASK) == align)
> > +			code |= STK_TEXT_FORMAT_NO_ALIGN;
> > +  
> 
> So I think the above code is actually incorrect.  The spec talks about
> Language dependent (default) alignment being equal to
> STK_DEFAULT_TEXT_ALIGNMENT.  So if the SIM sends us a Left aligned
> attribute, it really means Left aligned.
> 
> Maybe something like this is enough?
> 
> if (start == 0)
> 	align = STK_TEXT_FORMAT_NO_ALIGN;
> else
> 	align = formats[start - 1] & STK_TEXT_FORMAT_ALIGN_MASK;

I agree with you that this does not match the spec.  I did this
deliberately, because I had a problem deciding how to deal with 
the test case which you requested I include, which was defined 
in test_sms.c (header_test).  I included the test case below
for your reference.

static struct html_attr_test html_attr_data_1 = {
        .text = "EMS messages can contain italic, bold, large, small and "
                "colored text",
        .text_attr = {
                .len = 20,
                .attributes = { 0x19, 0x06, 0x20, 0x00, 0x21, 0x04, 0x10, 0x00,
                                0x27, 0x05, 0x04, 0x00, 0x2E, 0x05, 0x08, 0x00,
                                0x38, 0x07, 0x00, 0x2B },
        },
        .html = "EMS messages can contain <span style=\"font-style: "
                "italic;\">italic</span>, <span style=\"font-weight: bold;\">"
                "bold</span>, <span style=\"font-size: big;\">large</span>, "
                "<span style=\"font-size: small;\">small</span> and "
                "<span style=\"color: #FFFF00;background-color: #C11B17;\">"
                "colored</span> text",
};

So, you have your first formatting at start position 0x19, with
format code 0x20, and color not set (0x00).  Since previously
you had no formatting from the beginning to byte 0x19, and this
formatting specifies an alignment value of 0, if we interpret
this the way you suggest we will now insert a <div > tag with
left alignment specified at character 0x19, which would cause
a break in the text.  So, we can chose to interpret left
alignment as really meaning left alignment, which would be
correct according to the spec, but if this test case is truly
representative of what SIMs might send us, then we are going to
have some weird looking strings resulting.

How would you suggest handling this?