[PATCH 3/3] Interpret "" Alpha Id as empty data object

[Gu, Yang]

Hi Denis,

>-----Original Message-----
>From: ofono-bounces at ofono.org [mailto:ofono-bounces at ofono.org] On Behalf Of
>Denis Kenzior
>Sent: Saturday, July 10, 2010 1:32 AM
>To: ofono at ofono.org
>Cc: Zaborowski, Andrew; Yang Gu
>Subject: Re: [PATCH 3/3] Interpret "" Alpha Id as empty data object
>
>On 07/09/2010 09:52 AM, Yang Gu wrote:
>> There needs to be a way to distinguish between no alphaid and "empty
>> data object" because on some occasions they have different meanings.  In
>> the Call Control envelope, no Alpha Identifier means the terminal can
>> inform the user about the call being modified by SIM while empty data
>> object means no hint should be given.
>
>I applied this one, however I noticed that lots of unit tests for things
>besides call control were affected.  Question to both of you: Should we
>g_free & NULL empty Alpha Identifiers in commands that do not allow this
>to be empty?

If we know the alpha_id in some ber-tlvs couldn't be empty, we need an extra check and report the error. But the question is do we know any?
Currently I think the empty alpha_id has similar meaning for the application.

>
>Regards,
>-Denis
>_______________________________________________
>ofono mailing list
>ofono at ofono.org
>http://lists.ofono.org/listinfo/ofono

Regards,
-Yang