[PATCH 1/9] stkutil: display text attributes as html

Denis Kenzior denkenz at gmail.com
Thu Jul 15 13:32:11 PDT 2010


Hi Andrew,

> One idea to handle this was for the text_to_html function to take a
> language parameter (for now it could just hardcode English) and decide
> the default alignment based on it.  Then default alignment (bits 0:3
> == 3) would be treated same as left (or right).

Yes that is another approach, however I think that this might be moot
anyway.  At least on my Sony Ericsson T610 the EMS composer defaults to
alignment 'Auto' (No Alignment in the protocol) and only adds
Left/Right/Center alignment when the user tells it to.

> 
> This assumes the test is correct afterall, because it's not clear from 23 040.
> 

I'm fairly sure the current test case is synthetic, so might not reflect
how EMS messages are created in the real world.

I added another test case to test-sms with a test message composed by my
T610.  That is the better test case to focus on.

Regards,
-Denis



More information about the ofono mailing list