[patch 08/20] sms: document the org.ofono.SMSMessage D-Bus interface

Inaky Perez-Gonzalez inaky.perez-gonzalez at intel.com
Mon Jul 26 13:41:37 PDT 2010


On Mon, 2010-07-26 at 11:05 -0700, Denis Kenzior wrote: 
> Hi Inaky,
> 
> >>> +SMS / Messaging interface
> >>> +=========================
> >>> +
> >>> +Service		org.ofono
> >>> +Interface	org.ofono.SMSMessage
> >>
> >> oFono API is full CamelCase, so this should be SmsMessage.
> > 
> > I disagree. It would be like that if SMS was a word, but it is an
> > acronym. It makes it quite confusing, if you ask me. If that's still how
> > you like it, I'll change it, but I think it is wrong to capitalize an
> > acronym.
> > 
> 
> Your objection has been noted.  However, pure camel case looks nicer and
> that is how most of the API already is (e.g. SmsManager, SimManager,
> UnlockPin, etc)  So please change it or name it simply 'Message'.

Changed to SmsMessage as discussed over IRC.



More information about the ofono mailing list