VS: [RFC PATCH 5/6] Support for concatenated SMS status report.

[Miettinen Pasi]

Hi Denis,
> Hi Pasi,
>
> > ---
> >  include/history.h |    2 +
> >  src/sms.c         |   67 ++++++++++++++++++++----
> >  src/smsutil.c     |  152
> >  +++++++++++++++++++++++++++++++++++++++++++++++++++++ src/smsutil.h
> |
> >   32 +++++++++++
|
> I suggest thinking about the data structure use some more.  In particular,
> using a list of struct mr_numbers is very inefficient.  Using a pair of bitmaps
> for mr numbers (which can only be 0..255) would be way more efficient and
> probably would make the code much easier to write.

I am not sure if I am quite getting what do you mean. Do you mean something
like:
struct mr_numbers {
        unsigned int mr1 : 8,
        unsigned int mr2 : 8,
        unsigned int mr3 : 8,
        unsigned int mr4 : 8
};
So there wouldn't be so much padding bits or what's your angle here?
If that is it, how to indicate the status of the mr (enum sms_status_report_result)?

Br,
Pasi