VS: [RFC PATCH 5/6] Support for concatenated SMS status report.

Miettinen Pasi pasi.miettinen at ixonos.com
Mon Jun 7 06:02:25 PDT 2010


Hi Denis,
> > Hi Pasi,
> >
> > > ---
> > >  include/history.h |    2 +
> > >  src/sms.c         |   67 ++++++++++++++++++++----
> > >  src/smsutil.c     |  152
> > >  +++++++++++++++++++++++++++++++++++++++++++++++++++++ src/smsutil.h
> > |
> > >   32 +++++++++++
> |
> > I suggest thinking about the data structure use some more.  In particular,
> > using a list of struct mr_numbers is very inefficient.  Using a pair of bitmaps
> > for mr numbers (which can only be 0..255) would be way more efficient and
> > probably would make the code much easier to write.
> 
> I am not sure if I am quite getting what do you mean. Do you mean something
> like:
|
> Br,
> Pasi

OK, now I noticed that there's some bitmapping done in sms_assembly and
now I am beginning to get at least some kind of sense.

Br,
Pasi




More information about the ofono mailing list