[PATCH 17/20] stkutil: Add the Event Download envelope builder

Denis Kenzior denkenz at gmail.com
Wed Jun 9 18:06:00 PDT 2010


Hi Andrew,

>  		/* Network Byte Order */
> -		unsigned int ipv4;
> +		guint32 ipv4;

Why?

> @@ -799,7 +909,9 @@ struct stk_frame_layout {
>   */
>  struct stk_frames_info {
>  	unsigned char id;
> -	unsigned char list[126];
> +	struct {
> +		unsigned int width, height;

do you mean unsigned char here?

> +	} list[66];

Do you mean 63 here?

>  	unsigned int len;
>  };
> 
> +		struct stk_reader_status card_reader_status;
> +		const char *language_selection;

Per IRC conversation, lets not use const pointers in these structures.

Can you resubmit patches 12, 13 and 17-20.  All others have been pushed.

Thanks,
-Denis


More information about the ofono mailing list