[RFC PATCH 2/2] sms: status report notify

Denis Kenzior denkenz at gmail.com
Thu Jun 10 09:14:56 PDT 2010


Hi Pasi,

> +	if (!sms_dcs_decode(s.deliver.dcs, &cls, NULL, NULL, NULL)) {
> +		ofono_error("Unknown / Reserved DCS.  Ignoring");
> +		return;
> +	}
> +

This reminds me, one other check I'd like you to make here is that the status 
report belongs to an SMS Submit, not an SMS Command.  See TP-SRQ in 23.040.  I 
like to be paranoid :)

Regards,
-Denis


More information about the ofono mailing list