[PATCH 17/20] stkutil: Add the Event Download envelope builder

[Andrzej Zaborowski]

Hi,

On 10 June 2010 03:06, Denis Kenzior <denkenz at gmail.com> wrote:
> Hi Andrew,
>
>>               /* Network Byte Order */
>> -             unsigned int ipv4;
>> +             guint32 ipv4;
>
> Why?

int has no guranteed size except at the ABI level.  So the SysV r4
ABIs for x86, ARM and amd64 make it 32-bit but you don't know what
happens elsewhere.  I'll remove this change as it's unlikely int will
be < 32-bit and if it's wider we don't care.  (I, too, prefer stdint
types like uint32_t).

>
>> @@ -799,7 +909,9 @@ struct stk_frame_layout {
>>   */
>>  struct stk_frames_info {
>>       unsigned char id;
>> -     unsigned char list[126];
>> +     struct {
>> +             unsigned int width, height;
>
> do you mean unsigned char here?

I'll change it to char, a;though int isn't bad as these are integers
(something you can perform arithmetics on, not like an 8-bit
identifier).

>
>> +     } list[66];
>
> Do you mean 63 here?

Yes :)

>
>>       unsigned int len;
>>  };
>>
>> +             struct stk_reader_status card_reader_status;
>> +             const char *language_selection;
>
> Per IRC conversation, lets not use const pointers in these structures.

Ok.

Regards