[PATCH 17/20] stkutil: Add the Event Download envelope builder

Denis Kenzior denkenz at gmail.com
Fri Jun 11 12:31:39 PDT 2010


Hi Andrew,

> Hi,
> 
> On 10 June 2010 03:06, Denis Kenzior <denkenz at gmail.com> wrote:
> > Hi Andrew,
> >
> >>               /* Network Byte Order */
> >> -             unsigned int ipv4;
> >> +             guint32 ipv4;
> >
> > Why?
> 
> int has no guranteed size except at the ABI level.  So the SysV r4
> ABIs for x86, ARM and amd64 make it 32-bit but you don't know what
> happens elsewhere.  I'll remove this change as it's unlikely int will
> be < 32-bit and if it's wider we don't care.  (I, too, prefer stdint
> types like uint32_t).

Lets go with uint32_t, I think everyone agrees it the better approach.

Regards,
-Denis


More information about the ofono mailing list