[PATCH 12/20] stkutil: Add the Call Control envelope builder

Andrzej Zaborowski andrew.zaborowski at intel.com
Fri Jun 11 13:04:21 PDT 2010


On 11 June 2010 21:34, Denis Kenzior <denkenz at gmail.com> wrote:
> Hi Andrew,
>
>
>> >> +/* Used both in the ENVELOPE message to UICC and response from UICC */
>> >> +struct stk_envelope_call_control {
>> >> +     /* Exactly one of the following 5 fields must be present */
>> >
>> > Why are we not using a union then?
>>
>> We don't know which one of 5 is valid if it's a union.  We could add a
>> field to indicate that but I guess it's simpler the way it is.
>
> It seems like a type + union might be better for the consumers of this
> structure though.

Okay, currenlty the UICC will be the only consumer but we may need to
be a consumer too, later.

Regards


More information about the ofono mailing list