[PATCH 05/11] test-server: Fix GIOChannel leak in create_tty

Zhenhua Zhang zhenhua.zhang at intel.com
Fri Jun 11 22:50:44 PDT 2010


Remove client_io and unref server_io after creating GAtServer.
---
 gatchat/test-server.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/gatchat/test-server.c b/gatchat/test-server.c
index 74ddd4d..5c1cfa4 100644
--- a/gatchat/test-server.c
+++ b/gatchat/test-server.c
@@ -722,7 +722,6 @@ static gboolean create_tty(const char *modem_path)
 	int master, slave;
 	char pty_name[256];
 	GIOChannel *server_io;
-	GIOChannel *client_io;
 
 	if (!modem_path)
 		return FALSE;
@@ -732,9 +731,6 @@ static gboolean create_tty(const char *modem_path)
 
 	set_raw_mode(slave);
 
-	client_io = g_io_channel_unix_new(slave);
-	g_io_channel_set_close_on_unref(client_io, TRUE);
-
 	g_print("new pty is created at %s\n", pty_name);
 
 	server_io = g_io_channel_unix_new(master);
@@ -747,6 +743,8 @@ static gboolean create_tty(const char *modem_path)
 		return FALSE;
 	}
 
+	g_io_channel_unref(server_io);
+
 	return TRUE;
 }
 
-- 
1.6.3.3



More information about the ofono mailing list