[PATCH 1/5] stk: Add parser for send ussd commands

[Gu, Yang]

Hi Denis,



>-----Original Message-----
>From: Denis Kenzior [mailto:denkenz at gmail.com]
>Sent: Saturday, June 19, 2010 3:04 AM
>To: ofono at ofono.org
>Cc: Gu, Yang
>Subject: Re: [PATCH 1/5] stk: Add parser for send ussd commands
>
>Hi Yang,
>
>> ---
>>  src/stkutil.c |   61
>>  +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>src/stkutil.h |
>>    9 ++++++++
>>  2 files changed, 70 insertions(+), 0 deletions(-)
>
>Patches 1, 2 and 5 have been applied.  As discussed previously we're skipping
>patches 3 and 4 for now.  Please note that I broke Patch 2 into two patches (1
>for decode_ussd in smsutil.[ch] and one for the unit test), but did not do any
>modifications beyond that.
>
>Again, please watch out for this.  If your patch touches something in two or
>more directories of oFono, please send multiple patches.

Thank you for applying the patches. But I have a question on this: Should we keep the code compile-able after each patch? Due to this consideration, I put those changes all in patch 2. This would sometimes be helpful when we want to investigate a regression after a bunch of patches. If this is not a requirement for this project, I will pay more attention on how to split the patches reasonably.


>Regards,
>-Denis


Regards,
-Yang