[PATCH] mbmmodem: Fix ip netmask should be 255.255.255.255

Marcel Holtmann marcel at holtmann.org
Tue Jun 22 23:58:23 PDT 2010


Hi Zhenhua,

> Change static IP netmask to 255.255.255.255.
> ---
>  drivers/mbmmodem/gprs-context.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/mbmmodem/gprs-context.c b/drivers/mbmmodem/gprs-context.c
> index cca5087..2d0e4e2 100644
> --- a/drivers/mbmmodem/gprs-context.c
> +++ b/drivers/mbmmodem/gprs-context.c
> @@ -48,7 +48,7 @@
>  
>  #define MAX_DNS 5
>  
> -#define STATIC_IP_NETMASK "255.255.255.248"
> +#define STATIC_IP_NETMASK "255.255.255.255"
>  
>  static const char *none_prefix[] = { NULL };
>  static const char *e2ipcfg_prefix[] = { "*E2IPCFG:", NULL };

did you see a problem with this or why do you propose this change. The
old f35xx gives this netmask back when using DHCP. What does the f36xx
and later return when using DHCP?

Regards

Marcel




More information about the ofono mailing list