[PATCH 1/1] install data file

[Marcel Holtmann]

Hi Martin,

> > >  Makefile.am |    2 +-
> > >  1 files changed, 1 insertions(+), 1 deletions(-)
> > >
> > > diff --git a/Makefile.am b/Makefile.am
> > > index fcee5e6..007d5b9 100644
> > > --- a/Makefile.am
> > > +++ b/Makefile.am
> > > @@ -45,7 +45,7 @@ INCLUDES = -I$(top_srcdir)/src -I$(top_builddir)/src
> > >
> > >  CLEANFILES = src/control.moc $(nodist_src_phonesim_SOURCES)
> > >
> > > -EXTRA_DIST = src/controlbase.ui src/default.xml src/GSMSpecification.xml
> > > +dist_pkgdata_DATA = src/controlbase.ui src/moblin.xml
> > src/GSMSpecification.xml
> > >
> > 
> > this looks wrong. You should not be installing src/controlbase.ui and
> > don't bother installing GSMSpecification.xml. I just put that into the
> > source code for reference.
> > 
> > Also if you wanna install default.xml, then it needs to be installed
> > in /etc/phonesim/ and not just somewhere.
> I am afraid that I am not be persuaded. ;-)
> 
> I think *.xml is the data file containing the AT commands simulation data, and not the config file. So I think it is not suitable to put it at /etc.
> And the proper place is data directory, /usr/share/phonesim. And install GSMSpecification.xml there is convenient for user to reference, they need not find the source package. 
> Think of wpa_s package, they will put all the types of conf example at example directory

I have no strong preference one way or the other. I would be fully okay
with having this installed in /usr/share/phonesim and have phonesim use
the default.xml by default.

So please send a patch that just installs the default.xml and verify
that it is installed properly. Check as I explained in my previous
email.

Regards

Marcel